fix(other): Fix null reference error when smtp account has no mailbox attached. #1451
Conversation
indridieinarsson
changed the title
indridieinarsson
changed the title
indridieinarsson
changed the title
modules/smtp/modules.php
Outdated
| @@ -1576,18 +1576,20 @@ public function process() { | |||
|
|
|||
| foreach ($servers as $server_id => $config) { | |||
| $mailbox = new Hm_Mailbox($server_id, $this->user_config, $this->session, $config); | |||
| if ($mailbox->connect()) { | |||
There was a problem hiding this comment.
The connection object is not instantiated because the $config object lacks the type property, which the Hm_Mailbox class needs to determine the appropriate connection object to instantiate. Therefore, the fix should simply involve adding a type property to the $config object.
There was a problem hiding this comment.
Right, but why is the config object missing a type - it should generally always be present...
There was a problem hiding this comment.
@mercihabam and @kroky : yes, right. There should be a type property there. But there isn't one. I have four accounts in my setup. 3 are "normal" imap (login with username and password) - they are ok. The fourth is a gmail account. That's the one where there is no 'type' property attached to. Can't really figure out why that is.
There was a problem hiding this comment.
You can add type key in these arrays: https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L197, https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L178, https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L116 and https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L128, https://github.com/cypht-org/cypht/blob/master/modules/nux/modules.php#L389
This should fix.
There was a problem hiding this comment.
thanks @josaphatim . I'll take a look at this
I found out that the 'type' property is there at some point - but once we enter this code path (sending scheduled messages) it has disappeared. Only for the gmail account.
I strongly suspect it to have something to do with the oauth2 mechanism, since that's the only difference between the gmail account and the other 3.
|
Second try. |
🍰 Pullrequest
Issue #1450 says it all. For some reason, I have an smtp account with no mailbox attached (I promise I didn't do anything funky with the config, all standard server configs through the web gui). This gives rise to a null reference error in the php code and an endless series of red "server error" warning dialogs in the web page.
Issues
#1450