Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update .node-version to 18 #642

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

MikeMcC399
Copy link
Contributor

This PR updates .node-version from 14 to 18. It can be used by node version managers or simply read by a user, in order to set up the recommended Node.js version to use the repo or to contribute to it.

According to the Node.js release schedule Node.js 14 enters end-of-life status on April 30, 2023. Node.js 18 has been the Long Term Support (LTS) version since October 25, 2022.

Compatibility

Node.js npm ci npm run local:run
14.21.1 many warnings successful
16.16.0 2 deprecations successful
16.20.0 2 deprecations successful
18.16.0 2 deprecations successful
19.9.0 2 deprecations successful
20.0.0 2 deprecations successful

Updating .node-version in this repository to 18 does not affect the compatibility with cypress-io/cypress 12.10.0 > .node-version which defines the Node.js value as 16.16.0. The package runs successfully also on Node.js 16.16.0.

Deprecations

Under Node.js 16 and later, npm ci produces the following warnings:

npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated puppeteer@18.1.0: < 19.4.0 is no longer supported

Verification

On Ubuntu 22.04, execute:

nvm install 18
npm ci
npm run local:run

and confirm that all Cypress tests run successfully.

Cypress is currently at version 12.10.0.

@MikeMcC399
Copy link
Contributor Author

The CircleCI issue was caused by a failure to install Firefox. This is a failure of the CircleCI infrastructure, not an error in this PR.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 19, 2023 12:51
@MikeMcC399

This comment was marked as resolved.

@mjhenkes mjhenkes merged commit 36576b2 into cypress-io:master Apr 20, 2023
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 1.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the update/node-version branch April 20, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants