Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove netlify-plugin-cypress #816

Merged

Conversation

MikeMcC399
Copy link
Collaborator

This PR removes the npm module netlify-plugin-cypress from this repo.

Issues

Following the README > Help + Testing instructions to execute

npm install

causes supportability and vulnerability issues:

  1. The netlify-plugin-cypress uses an unsupported version of the npm module puppeteer 18.1.0. The minimum supported version of puppeteer is however 21.8.0:

    $ npm show puppeteer@18.1.0 deprecated
    < 21.8.0 is no longer supported

  2. npm audit identifies multiple security vulnerabilities that can be traced back to dependencies of netlify-plugin-cypress. These vulnerabilities can not be remediated with a simple npm audit fix
    • @koa/cors <5.0.0 Severity: high
    • debug 4.0.0 - 4.3.0
    • got <11.8.5 Severity: moderate

Situation

Changes

The following changes are made to resolve the issues listed above:

The change only affects the demonstration of netlify-plugin-cypress as a CI function. It does not affect the use of the repo contents for scaffolding examples in Cypress.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator Author

The repo would also need to be disabled on https://app.netlify.com/sites/cypress-example-kitchensink before merging this PR. I don't have any write access to these settings.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 27, 2024 17:24
@jennifer-shehane jennifer-shehane merged commit 7aed5ed into cypress-io:master Mar 28, 2024
10 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/netlify-plugin-cypress branch March 28, 2024 19:30
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation deprecations caused by netlify-plugin-cypress
3 participants