Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create ESLint v8 .eslintrc.js config #1570

Closed
wants to merge 4 commits into from

Conversation

MikeMcC399
Copy link
Contributor

Issue

The configuration for ESLint is defined in package.json eslintrc format. ESLint JSON configurations, including definitions stored in package.json, are deprecated in ESLint v9.

"eslintConfig": {
"env": {
"cypress/globals": true
},
"extends": [
"react-app",
"plugin:prettier/recommended",
"plugin:cypress/recommended"
],
"plugins": [
"cypress",
"prettier"
],
"rules": {
"no-unused-expressions": 0
}
},

Change

  • Move the ESLint configuration from package.json to a new file: .eslintrc.js and convert from JSON to JavaScript format. This is an interim step in preparation for an update to ESLint 9.x.
  • Update to eslint@^8.57.0 (final version of ESLint 8.x) in package.json. (This version was already in use in yarn.lock.)

Verification

yarn
yarn eslint .

update eslint to 8.57.0 in package.json
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 12, 2024 15:36
@MikeMcC399 MikeMcC399 marked this pull request as draft August 13, 2024 09:57
@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 13, 2024 15:32
@MikeMcC399
Copy link
Contributor Author

Withdrawn, as this repo is not ready for migration to ESLint 9, therefore there are no immediate advantages to merging this PR.

@MikeMcC399 MikeMcC399 closed this Sep 5, 2024
@MikeMcC399 MikeMcC399 deleted the create-.eslintrc.js branch September 5, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants