Skip to content

Conversation

astone123
Copy link
Contributor

@astone123 astone123 commented Sep 16, 2025

Additional details

In order to handle cloud/project authentication states, we need to pass the user cloud states to the studio panel.

Steps to test

See the services PR

How has the user experience changed?

PR Tasks

@astone123 astone123 self-assigned this Sep 16, 2025
Copy link

cypress bot commented Sep 16, 2025

cypress    Run #65835

Run Properties:  status check passed Passed #65835  •  git commit 3f7b08b3ff: Merge branch 'develop' into studio-ai-states
Project cypress
Branch Review studio-ai-states
Run status status check passed Passed #65835
Run duration 19m 45s
Commit git commit 3f7b08b3ff: Merge branch 'develop' into studio-ai-states
Committer Adam Stone-Lord
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 14
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26666
View all changes introduced in this branch ↗︎
UI Coverage  44.73%
  Untested elements 189  
  Tested elements 157  
Accessibility  97.71%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 110  

@astone123 astone123 changed the title chore: (studio) pass UserProjectStatusStore to cloud studio chore: (studio) AI status updates Sep 23, 2025
@astone123 astone123 marked this pull request as ready for review September 23, 2025 20:12
cursor[bot]

This comment was marked as outdated.

@astone123 astone123 requested a review from mabela416 September 25, 2025 18:40
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: React Component Fails to Update with New Props

The StudioPanel.vue component passes new props (hasRequestedProjectAccess, userProjectStatusStore) to the child React component. Without watch statements for these props, similar to canAccessStudioAI and cloudStudioSessionId, the React component won't re-render when their values change. This means the Studio panel may not update to reflect the latest state.

packages/app/src/studio/StudioPanel.vue#L141-L143

},
name: 'app',
})

packages/app/src/studio/StudioPanel.vue#L93-L95

// If vue tracks it (e.g. using a ref) it creates proxies that do not play nicely with React in
// production
let reactRoot = containerReactRootMap.get(container.value)

packages/app/src/studio/StudioPanel.vue#L102-L104

reactRoot?.render(panel)
}

Fix in Cursor Fix in Web


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants