chore: bundle the root package.json as an installable package #32544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AtofStryker
force-pushed
the
chore/bundle_package_root
branch
from
3e947b7 to
8033db1
Compare
AtofStryker
force-pushed
the
chore/bundle_package_root
branch
from
8033db1 to
ba709b7
Compare
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/bundle_package_root
|
| Run status |
|
| Run duration | 16m 40s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
132
|
Skipped
|
0
|
Passing
|
5583
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
changes
@packages/rootto bundle the rootpackage.jsonso@packages/rootcan be an true installable package. This means that regardless of where the package is installed, it will always be able to "discover" the rootpackage.json, which is used in a few packages, such as theconfig,types, etc.This step is crucial in order to make the other packages bundle from source.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?