-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: Update v8 snapshot cache - windows #32998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update v8 snapshot cache - windows #32998
Conversation
| ], | ||
| "deferredHashFile": "yarn.lock", | ||
| "deferredHash": "e687b38af49b78363a8f9ecc0de4199d8f2e8f616c8e5c58f4b75fe2e3446e65" | ||
| "deferredHash": "5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent snapshot cache hashes across platforms
The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.
| ], | ||
| "deferredHashFile": "yarn.lock", | ||
| "deferredHash": "e687b38af49b78363a8f9ecc0de4199d8f2e8f616c8e5c58f4b75fe2e3446e65" | ||
| "deferredHash": "5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent snapshot cache hashes across platforms
The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
update-v8-snapshot-cache-on-develop-windows
|
| Run status |
|
| Run duration | 22m 45s |
| Commit |
|
| Committer | cypress-bot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
9
|
|
|
1097
|
|
|
4
|
|
|
26697
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
This PR was automatically generated by the update-v8-snapshot-cache github action.
Note
Updates win32 v8 snapshot metadata
deferredHashintooling/v8-snapshot/cache/win32/snapshot-meta.jsonto match the currentyarn.lock.Written by Cursor Bugbot for commit c9b6837. This will update automatically on new commits. Configure here.