Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2025

This PR was automatically generated by the update-v8-snapshot-cache github action.


Note

Updates win32 v8 snapshot metadata deferredHash in tooling/v8-snapshot/cache/win32/snapshot-meta.json to match the current yarn.lock.

Written by Cursor Bugbot for commit c9b6837. This will update automatically on new commits. Configure here.

],
"deferredHashFile": "yarn.lock",
"deferredHash": "e687b38af49b78363a8f9ecc0de4199d8f2e8f616c8e5c58f4b75fe2e3446e65"
"deferredHash": "5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent snapshot cache hashes across platforms

The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.

Fix in Cursor Fix in Web

],
"deferredHashFile": "yarn.lock",
"deferredHash": "e687b38af49b78363a8f9ecc0de4199d8f2e8f616c8e5c58f4b75fe2e3446e65"
"deferredHash": "5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent snapshot cache hashes across platforms

The Windows snapshot cache hash is being updated to a different value than the darwin and linux caches. Since all three platform caches reference the same yarn.lock file via deferredHashFile, they should have identical deferredHash values. The darwin and linux caches both have hash 30957eb11212e6ebe537d8580a493219e1625eb6a65e3962e93b8dbe9e6d9e1c, but this change sets the Windows cache to 5a2412306b98e7753f91a9062a00f7326950dba66f0698527ed54b0d3d237da2. This inconsistency means the snapshot caches are out of sync across platforms, potentially causing different snapshot regeneration behavior and runtime inconsistencies.

Fix in Cursor Fix in Web

@cypress
Copy link

cypress bot commented Nov 23, 2025

cypress    Run #67527

Run Properties:  status check failed Failed #67527  •  git commit c9b6837081: Merge commit 'stash' into update-v8-snapshot-cache-on-develop-windows
Project cypress
Branch Review update-v8-snapshot-cache-on-develop-windows
Run status status check failed Failed #67527
Run duration 22m 45s
Commit git commit c9b6837081: Merge commit 'stash' into update-v8-snapshot-cache-on-develop-windows
Committer cypress-bot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 1097
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26697
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.48%
  Untested elements 188  
  Tested elements 161  
Accessibility  98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/commands/files.cy.js • 1 failed test • 5x-driver-firefox

View Output

Test Artifacts
src/cy/commands/files > #readFile > retries to read when ENOENT
    </td>
  </tr></table>
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > stops waiting when an xhr request is canceled
    </td>
  </tr></table>

The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud.

@jennifer-shehane jennifer-shehane merged commit fa62998 into develop Nov 24, 2025
86 of 91 checks passed
@jennifer-shehane jennifer-shehane deleted the update-v8-snapshot-cache-on-develop-windows branch November 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants