-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rule to disallow usage of cypress-xpath #247
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete the documentation by following the instructions in Document generation:
This plugin uses the ESLint eslint-doc-generator to generate consistent documentation.
- Install with
npm install eslint-doc-generator -g
- Run
eslint-doc-generator
in the root directory of the plugin
There are some different terms to take care of:
For consistency with other rules in the table https://github.com/cypress-io/eslint-plugin-cypress/blob/master/README.md#rules I suggest that the description should be "disallow using |
Hi Mike, thanks for the comments. I've tried to address them - let me know what you think of it |
fix pr/247
Wow thanks for the support. Indeed I see some changes in doc, I must have run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duranbe
Thanks for your initiative to resolve this request. 👍🏻 I have approved it as an external contributor.
We have to wait for the Cypress.io team to now review before it can be merged.
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Congratulations! 🎉 Your PR has been merged and a new version has been released! |
This PR implements the feature following issue #218
It is implementing a simple rule to match usage of
cy.xpath
I followed existing rules and https://github.com/cypress-io/eslint-plugin-cypress/blob/master/CONTRIBUTING.md
npm run lint
☑️npm run test
☑️