Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set side-effects-cache=false for pnpm #1364

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

Caching the pnpm store with default settings leads pnpm to skip running the Cypress postinstall script if the Cypress npm module is already cached. This may lead to failures if the Cypress cache is lost or purged.

Workflows should never depend on the presence of particular caches. They should always be resilient to missing caches.

Change

Add side-effects-cache=false using an .npmrc file to the:

Verification

  1. Run workflow for basic-pnpm
  2. Delete Cypress caches cypress-win23-* / cypress-darwin-* / cypress-linux-* in the branch under test
  3. Run workflow again and confirm that Cypress tests are run and are successful

@MikeMcC399 MikeMcC399 added documentation Improvements or additions to documentation topic: caching 📦 ci labels Feb 18, 2025
@MikeMcC399 MikeMcC399 self-assigned this Feb 18, 2025
@cypress-app-bot
Copy link

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 18, 2025 14:58
@jennifer-shehane jennifer-shehane merged commit 94eee4f into cypress-io:master Feb 18, 2025
76 checks passed
Copy link

🎉 This PR is included in version 6.7.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the disable/pnpm-side-effects-cache branch February 18, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci documentation Improvements or additions to documentation released topic: caching 📦
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cypress binary missing" error using pnpm cache
3 participants