Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚🩹 Fix broken demos in the docs are broken due to 404 error fetching cytoscape.min.js #3260

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

s-weigand
Copy link

@s-weigand s-weigand commented Jul 14, 2024

Associated issues:

Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.

Remove the --parents flag. The copy is now recursive by default. To get flat output, use the --flat flag.

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • N/A -- Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

closes #3259
closes #3257

Copy link
Member

@maxkfranz maxkfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'd revert the gitignore

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Max Franz <maxkfranz@gmail.com>
@s-weigand s-weigand requested a review from maxkfranz July 16, 2024 20:57
Copy link
Member

@maxkfranz maxkfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@maxkfranz maxkfranz merged commit 7215288 into cytoscape:master Jul 18, 2024
1 check passed
maxkfranz added a commit that referenced this pull request Jul 18, 2024
…demos

📚🩹 Fix broken demos in the docs are broken due to 404 error fetching `cytoscape.min.js`
@maxkfranz
Copy link
Member

Merged and cherry-picked to unstable branch. Thanks @s-weigand . Great PR

@s-weigand s-weigand deleted the fix-demos branch July 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants