Add reply field to Post struct#10
Merged
cyypherus merged 3 commits intocyypherus:mainfrom Feb 5, 2026
Merged
Conversation
Owner
|
Thank you for the PR! I see that the model for post references in atrium also contains cid. I'm wondering if there should be something like a universal "post reference" model in skyfeed. // From atrium api
#[derive(serde::Serialize, serde::Deserialize, Debug, Clone, PartialEq, Eq)]
#[serde(rename_all = "camelCase")]
pub struct MainData {
pub cid: crate::types::string::Cid,
pub uri: String,
}We already have a post reference sort of model for quoted posts which could use the same type. #[derive(Debug, Clone)]
pub struct QuoteEmbed {
pub cid: Cid,
pub uri: String,
}What are your thoughts? Is there a chance you'd need the cid? Just considering our options 🤗 |
Contributor
Author
|
well, for my use case I only actually need maybe if someone else needs the CID they can implement some |
cyypherus
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello! i added the reply field from posts to allow feed generators to filter out replies (or handle them differently). the ReplyRef matches the structure in the atproto post record :-)