More robust calculation of "z-step_um" for ndtiff datasets #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
added
bug
ziw-liu
reviewed
Dec 7, 2024
ziw-liu
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Diff reads good! I'll leave the actual testing to @ahillsley.
ahillsley
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculations of
z-step_umfails if the dataset has only a single z slice. In that case,ZPosition_um_Intendedexists in the metadata, but the dataset does not have images atz_idx = 1. Here I've wrapped the calculation ofz-step_umin a try/except statement which would catch both cases.@ahillsley please confirm that this PR fixes your issue and approve it.