Certify Controller & add/Remove Instructor fixups

czqoocavatsim · Aug 23, 2024 · 9f9eee0 · 9f9eee0
1 parent ecb55b5
commit 9f9eee0
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/app/Http/Controllers/Training/InstructingController.php b/app/Http/Controllers/Training/InstructingController.php
@@ -488,7 +488,7 @@ public function certifyStudent($cid)
         }
 
         // Unassign Instructor from Student
-        $instructor_link = InstructorStudentAssignment::where('student_id', $cid);
+        $instructor_link = InstructorStudentAssignment::where('student_id', $student->id);
         $instructor_link->delete();
 
         // Create new certification (for home page)
@@ -613,7 +613,7 @@ public function assignStudentToInstructor(Request $request, $student_id)
         $link->save();
 
         // Update Thread Tag
-        if ($student->user->hasDiscord() && $student->user->member_of_czqo) {
+        if ($student->user->member_of_czqo) {
             $discord = new DiscordClient();
             $discord->EditThreadTag('In Progress', $student->user->id);
         }
@@ -642,6 +642,12 @@ public function dropStudentFromInstructor($student_id)
             $label->delete();
         }
 
+        // Update Thread Tag
+        if ($student->user->member_of_czqo) {
+            $discord = new DiscordClient();
+            $discord->EditThreadTag('Ready For Pick-Up', $student->user->id);
+        }
+
         //Assign it with link
         $link = new StudentStatusLabelLink([
             'student_id'              => $student->id,