Skip to content

Commit

Permalink
Replace rlib crate-type with lib
Browse files Browse the repository at this point in the history
We don't really need the library to be an rlib from what I gather. We
need it to be available as:
- a static library (staticlib)
- a dynamic library (cdynlib)
- and as a Rust library

For the latter, lib is the default [0] (which likely is just an alias
for rlib) and I don't think we have any good reason to overwrite this
default. Also sneak in a comment fix while at it.

[0]: https://doc.rust-lang.org/reference/linkage.html

Signed-off-by: Daniel Müller <deso@posteo.net>
  • Loading branch information
d-e-s-o committed Aug 7, 2023
1 parent a5a7825 commit 4df406e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ autobenches = false

[lib]
name = "blazesym"
crate-type = ["cdylib", "rlib", "staticlib"]
crate-type = ["lib", "cdylib", "staticlib"]

[features]
default = ["demangle", "dwarf", "lru"]
Expand Down
2 changes: 1 addition & 1 deletion src/dwarf/units.rs
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ impl<'dwarf> Units<'dwarf> {
res_units.push(Unit::new(dw_unit, lang, lines))
}

// Sort this for faster lookup in `find_unit_and_address` below.
// Sort this for faster lookups.
unit_ranges.sort_by_key(|i| i.range.begin);

// Calculate the `max_end` field now that we've determined the order of
Expand Down

0 comments on commit 4df406e

Please sign in to comment.