Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts-type-expand-plugin): support vue language #393

Merged
merged 2 commits into from
May 16, 2024
Merged

feat(ts-type-expand-plugin): support vue language #393

merged 2 commits into from
May 16, 2024

Conversation

zcf0508
Copy link
Contributor

@zcf0508 zcf0508 commented May 16, 2024

  1. install vue.volar extension above 2.0.16
  2. enable the Hybrid Mode

image

image

@zcf0508
Copy link
Contributor Author

zcf0508 commented May 16, 2024

mxsdev/ts-type-explorer#45

@d-kimuson
Copy link
Owner

Related #330

@d-kimuson
Copy link
Owner

Thank you for your contribution!

I've been wanting to support Vue but haven't had the chance to start, so I really appreciate this. Everything seems to be working fine on my end. I'll review the changes, and if there are no issues, I'll merge them as they are.

d-kimuson
d-kimuson requested changes May 16, 2024
View reviewed changes
Copy link
Owner

@d-kimuson d-kimuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. I’ve made a few minor comments, so please address those.

packages/ts-type-expand-plugin/src/server/context.ts Outdated Show resolved Hide resolved
packages/ts-type-expand-plugin/src/server/context.ts Outdated Show resolved Hide resolved
packages/ts-type-expand-plugin/src/service/vue.ts Outdated Show resolved Hide resolved
packages/ts-type-expand-plugin/src/index.ts Outdated Show resolved Hide resolved
packages/ts-type-expand-plugin/src/index.ts Outdated Show resolved Hide resolved
d-kimuson
d-kimuson approved these changes May 16, 2024
View reviewed changes
Copy link
Owner

@d-kimuson d-kimuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!
I’ll let you know once it's released.

@d-kimuson d-kimuson merged commit 5ca5d29 into d-kimuson:main May 16, 2024
10 checks passed
@d-kimuson
Copy link
Owner

I’ve released a new version with added support for Vue!
Release: https://github.com/d-kimuson/ts-type-expand/releases/tag/v1.2.0

@zcf0508 zcf0508 mentioned this pull request May 16, 2024
Merged
@zcf0508 zcf0508 deleted the feat/vue branch May 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-kimuson d-kimuson d-kimuson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcf0508 @d-kimuson