feat(markuplint): require command attribute on button elements #802
+211
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rule to enforce Invoker Commands API usage on button elements with type="button". Two separate rules are added: 1. Require command attribute on button[type=button] elements - Exceptions: buttons with role attribute, form buttons (submit/reset/no type) 2. Encourage migration from popovertarget to Invoker Commands API - Display dedicated message for buttons with popovertarget attribute Update README to document all included rules in the config. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive test cases for the new button command attribute validation: - Test type="button" buttons requiring command attribute - Test exceptions: role attributes, form buttons (submit/reset/no type) - Test popovertarget migration warning - Test edge cases and multiple attribute combinations Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Markuplint rule to require
commandattribute onbutton[type=button]elements, enforcing Invoker Commands API usage for accessible UI implementation.Changes
1. New Markuplint Rules
Require command attribute on
button[type=button]button[type=button]:not([role]):not([popovertarget])Encourage popovertarget migration
button[popovertarget]:not([command]):not([role]):not([type=submit]):not([type=reset])2. Documentation
3. Tests
Test Plan
🤖 Generated with Claude Code