This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
refactor: combine PC host and port into a single url var #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it simpler for clients to provide a single input field and not have to do any parsing to split the hostname and port. It also allows us to use API validation for bad input.
dkoshkin
force-pushed
the
dkoshkin/refactor-pc-url
branch
from
681e4f5 to
a0b225c
Compare
supershal
reviewed
Apr 8, 2024
supershal
approved these changes
Apr 8, 2024
faiq
approved these changes
Apr 8, 2024
jimmidyson
pushed a commit
that referenced
this pull request
Apr 11, 2024
* refactor: combine PC host and port into a single url var This makes it simpler for clients to provide a single input field and not have to do any parsing to split the hostname and port. It also allows us to use API validation for bad input. * fixup! refactor: combine PC host and port into a single url var * fixup! refactor: combine PC host and port into a single url var * fixup! refactor: combine PC host and port into a single url var
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to hear the team's thoughts on this.
@supershal originally brought this up in the original PR.
This makes it simpler for clients to provide a single input field and not have to doany parsing to split the hostname and port.
It also allows us to use API validation for bad input.