This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
reviewed
Mar 26, 2024
jimmidyson
reviewed
Mar 26, 2024
faiq
force-pushed
the
faiq/add-nutanix-csi
branch
4 times, most recently
from
March 27, 2024 17:08
7cd1236
to
478110f
Compare
dkoshkin
reviewed
Mar 27, 2024
pkg/handlers/generic/lifecycle/clusterautoscaler/strategy_helmaddon.go
Outdated
Show resolved
Hide resolved
dkoshkin
reviewed
Mar 27, 2024
faiq
force-pushed
the
faiq/add-nutanix-csi
branch
from
March 27, 2024 23:39
6bb3eae
to
bb59ff1
Compare
jimmidyson
reviewed
Mar 28, 2024
jimmidyson
previously requested changes
Mar 28, 2024
jimmidyson
reviewed
Mar 28, 2024
It looks like delivering the storage classes via cluster resource set is working. 01:52 PM faiqus @ archlinux ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix faiq/add-nutanix-csi⚡?
$ kubectl get cm aws-storageclass-cm -o yaml
apiVersion: v1
data:
custom-resources.yaml: |-
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
annotations:
storageclass.kubernetes.io/is-default-class: "true"
creationTimestamp: null
name: aws-ebs
namespace: default
parameters:
csi.storage.k8s.io/fstype: ext4
encrypted: "true"
type: gp3
provisioner: aws-ebs
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
kind: ConfigMap
metadata:
creationTimestamp: "2024-03-28T19:50:27Z"
name: aws-storageclass-cm
namespace: default
ownerReferences:
- apiVersion: addons.cluster.x-k8s.io/v1beta1
kind: ClusterResourceSet
name: aws-storageclass-crs
uid: 5b37ccaf-7674-461e-aa01-a007c630500b
resourceVersion: "3373"
uid: b400598a-877e-4e84-97fa-d032dc91a287
01:53 PM faiqus @ archlinux ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix ⏎ 130 faiq/add-nutanix-csi⚡?
$ clusterctl get kubeconfig dawginme7 >> dawg7.conf
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"
01:53 PM faiqus @ archlinux ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix faiq/add-nutanix-csi⚡?
$ kubectl --kubeconfig=dawg7.conf get sc
NAME PROVISIONER RECLAIMPOLICY VOLUMEBINDINGMODE ALLOWVOLUMEEXPANSION AGE
aws-ebs (default) aws-ebs Delete WaitForFirstConsumer false 3m30s
01:53 PM faiqus @ archlinux ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix faiq/add-nutanix-csi⚡?
$ kubectl --kubeconfig=dawg7.conf get po -n kube-system | grep csi
ebs-csi-controller-74fcb959f9-pdk62 6/6 Running 0 4m
ebs-csi-controller-74fcb959f9-rgt4m 6/6 Running 0 4m
ebs-csi-node-dq65g 3/3 Running 0 3m10s
ebs-csi-node-q8tpn 3/3 Running 0 3m59s We can see that the storage class and the driver are configured on the workload cluster |
faiq
commented
Mar 29, 2024
faiq
force-pushed
the
faiq/add-nutanix-csi
branch
2 times, most recently
from
March 29, 2024 18:37
ea32369
to
bb5fb37
Compare
dlipovetsky
reviewed
Mar 29, 2024
dkoshkin
reviewed
Mar 29, 2024
faiq
force-pushed
the
faiq/add-nutanix-csi
branch
2 times, most recently
from
March 29, 2024 20:17
bfa63ff
to
cb080d9
Compare
dkoshkin
reviewed
Apr 1, 2024
dkoshkin
previously approved these changes
Apr 1, 2024
faiq
force-pushed
the
faiq/add-nutanix-csi
branch
from
April 1, 2024 17:55
c619e9c
to
7665a94
Compare
dkoshkin
approved these changes
Apr 1, 2024
supershal
approved these changes
Apr 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nutanix CSI.