Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

feat: add nutanix csi #7

Merged
merged 31 commits into from
Apr 1, 2024
Merged

feat: add nutanix csi #7

merged 31 commits into from
Apr 1, 2024

Conversation

faiq
Copy link

@faiq faiq commented Mar 22, 2024

Adds nutanix CSI.

@jimmidyson jimmidyson changed the title feat: add nutnaix csi feat: add nutanix csi Mar 26, 2024
@github-actions github-actions bot added feature and removed feature labels Mar 26, 2024
@faiq faiq force-pushed the faiq/add-nutanix-csi branch 4 times, most recently from 7cd1236 to 478110f Compare March 27, 2024 17:08
@faiq faiq marked this pull request as ready for review March 27, 2024 17:08
@faiq faiq force-pushed the faiq/add-nutanix-csi branch from 6bb3eae to bb59ff1 Compare March 27, 2024 23:39
pkg/handlers/generic/lifecycle/utils/utils.go Outdated Show resolved Hide resolved
pkg/handlers/generic/lifecycle/utils/utils.go Outdated Show resolved Hide resolved
api/v1alpha1/addon_types.go Outdated Show resolved Hide resolved
api/v1alpha1/addon_types.go Outdated Show resolved Hide resolved
@jimmidyson
Copy link
Member

I pushed some of the changes specifically around schema validation and updates to #10 - let me know what you think. Note that this requires the updated test utility in #9.

api/v1alpha1/addon_types.go Outdated Show resolved Hide resolved
api/v1alpha1/addon_types.go Outdated Show resolved Hide resolved
@jimmidyson jimmidyson self-requested a review March 28, 2024 17:24
@faiq
Copy link
Author

faiq commented Mar 28, 2024

It looks like delivering the storage classes via cluster resource set is working.

01:52 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡? 
$ kubectl get cm aws-storageclass-cm -o yaml
apiVersion: v1
data:
  custom-resources.yaml: |-
    apiVersion: storage.k8s.io/v1
    kind: StorageClass
    metadata:
      annotations:
        storageclass.kubernetes.io/is-default-class: "true"
      creationTimestamp: null
      name: aws-ebs
      namespace: default
    parameters:
      csi.storage.k8s.io/fstype: ext4
      encrypted: "true"
      type: gp3
    provisioner: aws-ebs
    reclaimPolicy: Delete
    volumeBindingMode: WaitForFirstConsumer
kind: ConfigMap
metadata:
  creationTimestamp: "2024-03-28T19:50:27Z"
  name: aws-storageclass-cm
  namespace: default
  ownerReferences:
  - apiVersion: addons.cluster.x-k8s.io/v1beta1
    kind: ClusterResourceSet
    name: aws-storageclass-crs
    uid: 5b37ccaf-7674-461e-aa01-a007c630500b
  resourceVersion: "3373"
  uid: b400598a-877e-4e84-97fa-d032dc91a287

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  ⏎ 130  faiq/add-nutanix-csi⚡? 
$ clusterctl get kubeconfig dawginme7 >> dawg7.conf
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"
Using configuration File="/home/faiqus/.cluster-api/clusterctl.yaml"

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡? 
$ kubectl --kubeconfig=dawg7.conf get sc
NAME                PROVISIONER   RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
aws-ebs (default)   aws-ebs       Delete          WaitForFirstConsumer   false                  3m30s

01:53 PM  faiqus @ archlinux  ~/go/src/github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix  faiq/add-nutanix-csi⚡? 
$ kubectl --kubeconfig=dawg7.conf get po -n kube-system | grep csi
ebs-csi-controller-74fcb959f9-pdk62                                 6/6     Running   0          4m
ebs-csi-controller-74fcb959f9-rgt4m                                 6/6     Running   0          4m
ebs-csi-node-dq65g                                                  3/3     Running   0          3m10s
ebs-csi-node-q8tpn                                                  3/3     Running   0          3m59s

We can see that the storage class and the driver are configured on the workload cluster

@faiq faiq dismissed jimmidyson’s stale review March 28, 2024 21:03

changes made!

@faiq faiq force-pushed the faiq/add-nutanix-csi branch 2 times, most recently from ea32369 to bb5fb37 Compare March 29, 2024 18:37
@faiq faiq force-pushed the faiq/add-nutanix-csi branch 2 times, most recently from bfa63ff to cb080d9 Compare March 29, 2024 20:17
dkoshkin
dkoshkin previously approved these changes Apr 1, 2024
@faiq faiq enabled auto-merge April 1, 2024 18:25
@faiq faiq merged commit 2ec54be into main Apr 1, 2024
16 checks passed
@faiq faiq deleted the faiq/add-nutanix-csi branch April 1, 2024 18:47
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants