Fix KeyError legacy['can_media_tag'] in User class #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses a potential Updated class diagram for the User classclassDiagram
class User {
+verified: bool
+possibly_sensitive: bool
+can_dm: bool
+can_media_tag: bool
+want_retweets: bool
+default_profile: bool
+default_profile_image: bool
}
note for User "The can_media_tag attribute is now safely retrieved using .get() with a default value of False."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe changes update the initialization of the Changes
Sequence Diagram(s)sequenceDiagram
participant L as Legacy Dictionary
participant U as User Constructor
U->>L: Retrieve 'can_media_tag' using .get()
alt Key exists
L-->>U: Return existing value
else Key missing
L-->>U: Return False
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ruizie - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a default value to other
legacy[...]calls to avoid similar issues.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter returned data where it caused a KeyError on
legacy['can_media_tag'], I do not have the particular test user profile, it was lost.. but I did pass through the same data a second time with this fix and no error occurred ever again.Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit