Check support for unsigned 64 bit integer values for sequence numbers #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no internal arithmetic or other operations that use the values of SeqNum fields. And Python's integers will scale transparently from fixed length to arbitrary length as required. Added test cases for both encoder and decoder, checking that it can handle values up to 2**64, which (per the bug report) is a billion messages a second for 584 years, so ... all good.
da4089
deleted the
50-support-unsigned-64-bit-integers-for-sequence-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FIX Continuous Markets WG is exploring 24/7/365 FIX operations, and is recommending that FIX applications and engines support 64 bit sequence numbers.
This change adds tests that confirm this works correctly.