Skip to content

fix rocksdb build on fedora by backporting an upstream patch #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derSteFfi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix rocksdb build on fedora by backporting an upstream patch #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7423bde
fix rocksdb build on fedora bz backporting an upstream patch
Jul 18, 2025
5b538ff
fix another instance of missing cstdint
Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build-bench-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,9 @@ if test "$setup_rocksdb" = "1"; then
fi

cd "rocksdb-$version_rocksdb"
set +e
patch -p1 -N -r- < ../../patches/rocksdb_build.patch > /dev/null
set -e
DISABLE_WARNING_AS_ERROR=1 DISABLE_JEMALLOC=1 ROCKSDB_DISABLE_TCMALLOC=1 make db_bench -j $procs
[ "$CI" ] && find . -name '*.o' -delete
popd
Expand Down
28 changes: 28 additions & 0 deletions patches/rocksdb_build.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# backported from https://github.com/facebook/rocksdb/commit/a4f2d46ab6065eb43ee781b0d57c29787780d935
diff --git a/db/blob/blob_file_meta.h b/db/blob/blob_file_meta.h
index d7c8a124336..2e47726f8d1 100644
--- a/db/blob/blob_file_meta.h
+++ b/db/blob/blob_file_meta.h
@@ -6,6 +6,7 @@
#pragma once

#include <cassert>
+#include <cstdint>
#include <iosfwd>
#include <memory>
#include <string>

# backported from https://github.com/facebook/rocksdb/commit/e812a3d3b32ac159f2df99bcae4ca55173e790d5
diff --git a/include/rocksdb/trace_record.h b/include/rocksdb/trace_record.h
index 8f9c3ee2f0f..d0f1532aa3a 100644
--- a/include/rocksdb/trace_record.h
+++ b/include/rocksdb/trace_record.h
@@ -8,7 +8,7 @@
#include <memory>
#include <string>
#include <vector>
-
+#include <cstdint>
#include "rocksdb/rocksdb_namespace.h"
#include "rocksdb/slice.h"
#include "rocksdb/status.h"
Loading