Skip to content

Conversation

@derSteFfi
Copy link
Contributor

@derSteFfi derSteFfi commented Aug 7, 2025

pushing this draft as a starter to get your opinions - I'll be on vacation the next weeks and won't be working on it anyway. There are a few open tasks, but the general vibe should already come across. Feedback very welcome.

Decisions made:

  • VERSIONS: demand versions instead of reporting them in the end
  • switched from git cloning to grabbing a snapshot of the reqeuested version from github
  • dh: move build directory (dh/src/build -> dh/build)
  • lua: moved to extern benchmarks because it is built in extern/
  • benchmarks: if something is updated, CMakeLists.txt needs to be touched (or replaced with a Makefile longterm)
  • sm: instead of default target, switched to building supermalloc only
  • linux: updated version to LTS series
  • lean: switched to smaller build target

TODO

  • put archives in extra storage after versionizing them (see here) docker caches these already
  • adapt CI-scripts to use Makefile
  • package installation
    • document in README: bazel5 missing, rest is done
    • move to CI instead of build_bench_env.sh
  • bench.sh needs to be adapted in the way it finds 'installed allocators' -- fixed in Detect allocators present and functional #247

open Questions:

  1. partial_checkout
    1. scudo
    2. lp Also, github does not serve archives on that repo. Re-add when solved.
  2. pa: re-add, but smaller? (see here), but: Add partitionalloc #184
  3. sed patches in Makefile: port to proper patch? at least gd, hd, rp are patched with sed right now, we could port that to a patch

@derSteFfi derSteFfi changed the title replace build_bench_env.sh with a Makefile Draft: replace build_bench_env.sh with a Makefile Aug 7, 2025
@derSteFfi derSteFfi marked this pull request as draft August 7, 2025 13:35
@derSteFfi
Copy link
Contributor Author

one ToDo I forgot in notes: tar can exclude files from extraction. The current shell-script does delete a few folders in a few repositories - we could modify the tar call to not extract them in the first place.

Stephan Bauroth and others added 19 commits October 9, 2025 11:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes.

@jvoisin, @derSteFfi I don't want to hold these changes holding off on fixing issues for individual allocators/platforms. But I really like to only have a Green CI. Thoughts?

@derSteFfi
Copy link
Contributor Author

Absolutely agree. I still have at least scudo and lp on my list and will re-check all comments here afterwards. With that fixed, I would also be pro-merging to make it easier to hunt individual bugs. The branch-switching sometimes takes time, and we would have a clear stand - fixing individual things is much easier than to always have to model the whole process.

@derSteFfi derSteFfi force-pushed the build_with_makefile branch from 0266c64 to 2d0082e Compare October 13, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants