Skip to content

bench.sh: detect failed runs and fail accordingly #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derSteFfi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bench.sh: detect failed runs and fail accordingly #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ procs=8
repeats=1 # repeats of all tests
test_repeats=1 # repeats per test
sleep=0 # mini sleeps between tests seem to improve stability
error=0 # binary marker for errors during the run
failed_runs="" # accumulated failed runs
case "$OSTYPE" in
darwin*)
darwin="1"
Expand Down Expand Up @@ -559,16 +561,27 @@ function run_test_env_cmd { # <test name> <allocator name> <environment args> <c
case "$1" in
redis*)
echo "start server"
$timecmd -a -o "$benchres.line" -f "$1${benchfill:${#1}} $2${allocfill:${#2}} %E %M %U %S %F %R" /usr/bin/env $3 $redis_dir/redis-server > "$outfile.server.txt" &
sleep 1s
$redis_dir/redis-cli flushall
sleep 1s
tmpfile=$(mktemp)
(
$timecmd -a -o "$benchres.line" -f "$1${benchfill:${#1}} $2${allocfill:${#2}} %E %M %U %S %F %R" /usr/bin/env $3 $redis_dir/redis-server > "$outfile.server.txt"
echo $? > "$tmpfile"
) &
sleep 0.1
if [ -s "$tmpfile" ]; then
error="1"
failed_runs+="$1:$2 "
return
fi
rm -f "$tmpfile"
while true; do
$redis_dir/redis-cli flushall > /dev/null 2>&1
if test "$?" = "0"; then
break
fi
done
$4 >> "$outfile"
sleep 1s
$redis_dir/redis-cli flushall
sleep 1s
$redis_dir/redis-cli shutdown
sleep 1s
$redis_dir/redis-cli flushall > /dev/null
$redis_dir/redis-cli shutdown 2> /dev/null
;;
security)
echo $2 >> $outfile
Expand Down Expand Up @@ -602,7 +615,12 @@ function run_test_env_cmd { # <test name> <allocator name> <environment args> <c
done
;;
*)
$timecmd -a -o "$benchres.line" -f "$1${benchfill:${#1}} $2${allocfill:${#2}} %E %M %U %S %F %R" /usr/bin/env $3 $4 < "$infile" > "$outfile";;
$timecmd -a -o "$benchres.line" -f "$1${benchfill:${#1}} $2${allocfill:${#2}} %E %M %U %S %F %R" /usr/bin/env $3 $4 < "$infile" > "$outfile"
if test "$?" != "0"; then
error="1"
failed_runs+="$1:$2 "
fi
;;
esac

# fixup larson with relative time
Expand Down Expand Up @@ -797,3 +815,8 @@ do
echo ""
fi
done

if test "$error" != "0"; then
echo "Failed tests: $failed_runs"
exit 1
fi
Loading