Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to run generic pre- and post-task logic #65

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

james-certn
Copy link
Contributor

@james-certn james-certn commented Jun 19, 2024

I don't have the appropriate environment set up locally (there are no instructions?), so I have not run the test suite changes (they might fail abysmally!)

  • aiming to provide a way to hook in app-specific setup before each job task is run
    • have added both pre and post task hooks, for fun.
  • the example being to reset the structlog context, to ensure no pollution from one job to the next

TODO:

  • add tests
  • make documentation changes

@james-certn james-certn marked this pull request as ready for review June 20, 2024 17:55
@j4mie j4mie changed the title Add hook to run generic pre-job setup logic. Add hook to run generic pre- and post-task logic Jun 25, 2024
@j4mie j4mie merged commit 01a506c into dabapps:master Jun 25, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants