Add Django 5.2 and 6.0 to test matrix, remove Python 3.8 and 3.9#10
Merged
Add Django 5.2 and 6.0 to test matrix, remove Python 3.8 and 3.9#10
Conversation
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice update overall — this gets the matrix aligned with supported Django/Python versions and drops EOL combinations, which is great.
A couple of small points to consider:
-
Scope of this PR
- The title/description are about compatibility matrix changes, but this also upgrades CI actions and multiple dev tools.
- Not necessarily wrong, but splitting tooling upgrades into a separate PR can make failures easier to reason about (compatibility vs tooling regression).
-
GitHub Actions major versions
- Can you double-check that
actions/checkout@v6andactions/setup-python@v6are intentional and available in your target environment? - If they are, all good — just worth a quick sanity check since this is a major-version jump.
- Can you double-check that
Other than that, the matrix exclusions look sensible for avoiding unsupported Django/Python pairings.
j4mie
approved these changes
Feb 26, 2026
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice update overall — the Python/Django matrix changes and exclusions look sensible.
Only two carry-overs from my earlier review that still seem open in this diff:
- Can you confirm
actions/checkout@v6andactions/setup-python@v6are intentional for your target runners? - This still includes matrix/support changes plus tooling upgrades in one PR; if that’s deliberate, all good, but splitting (or at least clearly separating in commits) would still make CI regressions easier to diagnose.
If those are confirmed, I’m happy with this.
j4mie
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unsupported versions of Django and add latest.