Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Typescript #331

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Update Typescript #331

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8555f71
Update packages
Feb 14, 2020
7ddf666
Update packages
Mar 22, 2020
add7dfc
Merge branch 'master' into upgrade-typescript
nvlaarhoven Apr 16, 2020
90739a5
Revert package upgrades
nvlaarhoven Apr 16, 2020
e93f61e
Revert unwanted changes
nvlaarhoven Apr 16, 2020
b97126e
Upgrade typescript and react-docgen-typescript
nvlaarhoven Apr 16, 2020
e77f704
Fix ComponentProps and remove cast as any
nvlaarhoven Apr 16, 2020
0ca8782
Remove casting as never
nvlaarhoven Apr 16, 2020
efb71ba
Revert removing empty state
nvlaarhoven Apr 16, 2020
81a875a
Set component type to ReactType
nvlaarhoven Apr 16, 2020
8fbe000
Cast as ReactType
nvlaarhoven Apr 16, 2020
ba0f0d1
Remove casting as any
nvlaarhoven Apr 16, 2020
b77346d
Upgrade react and react-dom
nvlaarhoven Apr 21, 2020
3a47de8
Fix ComponentProps
nvlaarhoven Apr 21, 2020
1b224bf
No longer extend ComponentProps
nvlaarhoven Apr 21, 2020
9c17e82
Define storeRef as separate function
nvlaarhoven Apr 21, 2020
f9b04fc
Fix css
nvlaarhoven Apr 21, 2020
de482fa
Cast Component as ComponentType
nvlaarhoven Apr 21, 2020
8af9a7f
Add typecheck script
JakeSidSmith Apr 23, 2020
f946cce
Fix style prop types
JakeSidSmith Apr 23, 2020
0283b5b
Fix style prop types
JakeSidSmith Apr 23, 2020
6884dba
Enable no unused locals and parameters options
JakeSidSmith Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove casting as any
  • Loading branch information
@nvlaarhoven
nvlaarhoven committed Apr 16, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit ba0f0d1a45f9c44efd748bc2b8769a14be28876e
17 changes: 8 additions & 9 deletions tests/nav-bar.tsx
View file
Original file line number Diff line number Diff line change
@@ -171,15 +171,14 @@ describe('NavBar', () => {
jest.spyOn(utils, 'getScrollOffset').mockReturnValue({ x: 0, y: 0 });

const fakeElement = document.createElement('div');
fakeElement.getBoundingClientRect = () =>
({
height: 20,
bottom: 0,
left: 0,
right: 0,
width: 0,
top: 0,
} as any);
fakeElement.getBoundingClientRect = () => ({
height: 20,
bottom: 0,
left: 0,
right: 0,
width: 0,
top: 0,
});

jest.spyOn(ReactDOM, 'findDOMNode').mockReturnValue(fakeElement);