BROKEN: Upgrade to Drizzle React Context API #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 5, 2019 18:11
gichiba
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is where I've gotten to. I started out ambitious and have ended up systematically breaking everything.
I just want to know what is going on with the drizzle instance, because as far as I can tell it's not passing the
drizzleobject down as it should through the components, and this causes everything to have an empty state.I've left a bunch of comments in the code to help go through my reasoning. Might also be helpful to read the notes on the drizzle-react document:
https://github.com/trufflesuite/drizzle-react#using-the-react-context-api-for-react-v163
and although I removed it to (unsucessfully) figure out the more fundamental issues, maybe the
drizzle-react-componentscode might give some clues as to what the hell is going on here:https://github.com/trufflesuite/drizzle-react-components