Skip to content

Performance updates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbasten wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Performance updates #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 70 additions & 82 deletions FavoriteChannels/FavoriteChannels.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,31 +79,31 @@ public override bool BeforeInvoke(InvocationInfo info, out object returnValue)
return false;
}

if (isEmpty(favChannelsFilePath))
return false;

else
{
Console.WriteLine("File is not empty, gathering favorite channels!");
string line;

using (StreamReader reader = new StreamReader(favChannelsFilePath))
{
while ((line = reader.ReadLine()) != null)
{
if (!line.Contains("trading") && !line.Contains("general"))
{
FavoriteChannelsList.Add(line);
App.ArenaChat.RoomEnter(line);
}
}
}
}
if (isEmpty(favChannelsFilePath))
{
return false;
}
else
{
Console.WriteLine("File is not empty, gathering favorite channels!");
string line;

using (StreamReader reader = new StreamReader(favChannelsFilePath))
{
while ((line = reader.ReadLine()) != null)
{
if (!line.Contains("trading") && !line.Contains("general"))
{
FavoriteChannelsList.Add(line.ToLower()); // toLower for certainty
App.ArenaChat.RoomEnter(line);
}
}
}
}

return false;
}

if (info.targetMethod.Equals("sendRequest"))
else if (info.targetMethod.Equals("sendRequest"))
{
if (info.arguments[0] is RoomChatMessageMessage)
{
Expand All @@ -124,19 +124,18 @@ public override bool BeforeInvoke(InvocationInfo info, out object returnValue)
// splitted[1] instead of usernameToIgnore because of caps :)
msg("Added channel " + channelToAdd + " to FavoriteChannels list!");
}
else if (channelToAdd.Contains("trading") || channelToAdd.Contains("general"))
{
msg("Sorry but you may not add trading / general rooms to favorites.");
}

else
msg("Channel " + channelToAdd + " is already on the favorite channels list.");
else if (channelToAdd.Contains("trading") || channelToAdd.Contains("general"))
{
msg("Sorry but you may not add trading / general rooms to favorites.");
}
else
{
msg("Channel " + channelToAdd + " is already on the favorite channels list.");
}

return true;
}


if (rcmm.text.StartsWith("/addchannel") || rcmm.text.StartsWith("/ac"))
else if (rcmm.text.StartsWith("/addchannel") || rcmm.text.StartsWith("/ac"))
{
String[] splitted = rcmm.text.Split(' ');

Expand All @@ -154,21 +153,19 @@ public override bool BeforeInvoke(InvocationInfo info, out object returnValue)

msg("Added channel " + splitted[1] + " to FavoriteChannels list!");
}

else if (splitted[1].Contains("trading") || splitted[1].Contains("general"))
{
msg("Sorry but you may not add trading / general rooms to favorites.");
}

else
msg("Channel " + splitted[1] + " is already on the favorite channels list.");

else if (splitted[1].Contains("trading") || splitted[1].Contains("general"))
{
msg("Sorry but you may not add trading / general rooms to favorites.");
}
else
{
msg("Channel " + splitted[1] + " is already on the favorite channels list.");
}
}

return true;
}

if (rcmm.text.StartsWith("/removecurrentchannel") || rcmm.text.Equals("/rcc"))
else if (rcmm.text.StartsWith("/removecurrentchannel") || rcmm.text.Equals("/rcc"))
{
String channeltoRemove = App.ArenaChat.ChatRooms.GetCurrentRoom().ToLower();

Expand All @@ -188,73 +185,64 @@ public override bool BeforeInvoke(InvocationInfo info, out object returnValue)
// splitted[1] instead of usernameToIgnore because of caps :)
msg("Removed channel " + channeltoRemove + " from FavoriteChannels list!");
}

else
{
msg("Channel " + channeltoRemove + " was not on the favorites list.");
}

return true;
}

if (rcmm.text.StartsWith("/removechannel") || rcmm.text.StartsWith("/rc"))
else if (rcmm.text.StartsWith("/removechannel") || rcmm.text.StartsWith("/rc"))
{
String[] splitted = rcmm.text.Split(' ');

if (splitted.Length >= 2)
{
String channeltoRemove = splitted[1].ToLower();

if (FavoriteChannelsList.Contains(channeltoRemove)) //If channel is not on list already
{
FavoriteChannelsList.Remove(channeltoRemove);

File.Delete(favChannelsFilePath);

StreamWriter sw = new StreamWriter(favChannelsFilePath, true);
foreach (string s in FavoriteChannelsList)
{
sw.WriteLine(s);
}
sw.Close();

msg("Removed channel " + splitted[1] + " from FavoriteChannels list!");
}

else
msg(splitted[1] + " was not on the Favorite Channels list!");
if (FavoriteChannelsList.Contains(channeltoRemove)) //If channel is not on list already
{
FavoriteChannelsList.Remove(channeltoRemove);

File.Delete(favChannelsFilePath);

StreamWriter sw = new StreamWriter(favChannelsFilePath, true);
foreach (string s in FavoriteChannelsList)
{
sw.WriteLine(s);
}
sw.Close();

msg("Removed channel " + splitted[1] + " from FavoriteChannels list!");
}
else
{
msg(splitted[1] + " was not on the Favorite Channels list!");
}
}

return true;
}

if (rcmm.text.Equals("/listfavorites") || rcmm.text.Equals("/lf") || rcmm.text.Equals("/favorites"))
else if (rcmm.text.Equals("/listfavorites") || rcmm.text.Equals("/lf") || rcmm.text.Equals("/favorites"))
{
msg("Current favorite channels:");

if (FavoriteChannelsList.Count == 0)
msg("There are currently no favorite channels added! You can add a channel by typing '/ac [channelname]' or if you want to add your current channel, you can type '/acc'");

else
{
foreach (string s in FavoriteChannelsList)
{
msg(s);
}
}
if (FavoriteChannelsList.Count == 0)
{
msg("There are currently no favorite channels added! You can add a channel by typing '/ac [channelname]' or if you want to add your current channel, you can type '/acc'");
}
else
{
msg("Current favorite channels: " + String.Join(", ", FavoriteChannelsList.ToArray()));
}

return true;
}

if (rcmm.text.Equals("/fhelp") || rcmm.text.Equals("/fcommands") || rcmm.text.Equals("/favoriteshelp"))
else if (rcmm.text.Equals("/fhelp") || rcmm.text.Equals("/fcommands") || rcmm.text.Equals("/favoriteshelp"))
{
msg("Favorite Channels command list:");
printCommands();
return true;
}

}
return false;
}
return false;
}
Expand Down