Make samplers and While loops opaque
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaiser
changed the title
opaqueWhile loops opaque
stefan-aws
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: For while loops, the definition is not very helpful, it's better to rely on lemmas around it for proofs. When calling samplers, we should also not rely on their internals, but on their correctness properties. It also reduces resource usage.
As a concession, this PR also adds a postcondition for
Whileto avoid having to call a lemma to handle the case of a while loop immediately exiting.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.