Implementation, testing, and examples of Fisher-Yates #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-aws
changed the title
jtristan
requested changes
Jan 8, 2024
…hub.com/dafny-lang/dafny-vmc into fisher-yates-implementation-and-testing
fzaiser
reviewed
Jan 11, 2024
fzaiser
reviewed
Jan 11, 2024
| } | ||
|
|
||
| method TestEmpiricalIsWithin4SigmaOfTrueMean( | ||
| method TestEmpiricalIsWithin3SigmaOfTrueMean( |
There was a problem hiding this comment.
Just FYI: we had a threshold of 3 sigma before and quite regularly got spurious test failures with it, which is to be expected given our number of tests.
jtristan
reviewed
Jan 22, 2024
| return Uniform.Implementation._Companion_Trait.UniformSample(this, n); | ||
| } | ||
|
|
||
| public boolean CoinSample() { |
There was a problem hiding this comment.
A problem with doing this is that the Java API will be nicer, but is the idea that we should do this for every target?
jtristan
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.