Merge pull request #9 from neekfenwick/linear-algo-tallest-first

Make Linear algorithm sort tallest to shortest, rather than widest to…
dagmike · Feb 27, 2021 · 191794f · 191794f
2 parents ec35f70 + 9749baa
commit 191794f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
     "name": "dagmike/bin-packing",
-    "version": "1.7.1",
+    "version": "1.7.2",
     "description": "2D bin packing PHP implementation",
     "type": "library",
     "license": "MIT",

diff --git a/src/Algorithms/Linear.php b/src/Algorithms/Linear.php
@@ -28,7 +28,8 @@ public static function findNewPosition(
                 if ($freeRect->getWidth() >= $rectangle->getWidth()) {
                     $bestNode->setX($freeRect->getX());
                     $bestNode->setY($freeRect->getY());
-                    $bestX = $freeRect->getWidth() - $rectangle->getWidth();
+                    // Favour the tallest items first.
+                    $bestY = $freeRect->getHeight() - $rectangle->getHeight();
                     return $bestNode;
                 }
             }