Stdout stderr to vec plus error exit codes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kdesjard <kristian.desjardins@nrcan-rncan.gc.ca>
…e in the case of an error and allow for setting a Content payload Signed-off-by: kdesjard <kristian.desjardins@nrcan-rncan.gc.ca>
…or not. Convert stdout and stderr into a Vec of Strings for downstream use. In the case an error, attempt return the operating systems exit code Signed-off-by: kdesjard <kristian.desjardins@nrcan-rncan.gc.ca>
genedna
approved these changes
Dec 11, 2023
aminya
reviewed
Dec 17, 2023
| @@ -165,14 +166,14 @@ impl Output { | |||
| } | |||
|
|
|||
| /// Construct an [`Output`]` with an error message. | |||
| pub fn error(msg: String) -> Self { | |||
| Self::Err(msg) | |||
| pub fn error(code: Option<i32>, msg: String) -> Self { | |||
There was a problem hiding this comment.
@kdesjard This PR does not make sense for normal outputs when someone is not running Shell commands. Rust has rich error-handling features, which are much better than exit codes.
Also, this method is changed, which is a breaking change for all the users of Dagrs. We have to revert this change adding a new status field like ErrWithExitCode
This was referenced Dec 17, 2023
|
Sorry about this and thanks for the updates/fixes. |
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration as this pull request also contains breaking changes.
This request allows for the capture of stdout and stderr regardless of whether a task completes successfully. It also allows for the capturing of the OS's exit code in the case of a failure.
Thanks, Kris.