Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] - Make max runtime seconds configurable in the helm chart #27005

Merged

Conversation

marijncv
Copy link
Contributor

@marijncv marijncv commented Jan 10, 2025

Summary & Motivation

Adds parameter to configure run monitoring with max_runtime_seconds in the helm chart.

Closes #26641

How I Tested These Changes

Added a test

@danielgafni
Copy link
Contributor

Hey @marijncv, something weird is going with the build, could you rebase on master and try again please?

@marijncv marijncv requested a review from neverett as a code owner January 21, 2025 20:28
@marijncv marijncv force-pushed the configure-max-runtime-seconds-helm branch from 3a202f0 to dd83d31 Compare January 21, 2025 20:30
@marijncv marijncv force-pushed the configure-max-runtime-seconds-helm branch from dd83d31 to 05c5cf1 Compare January 21, 2025 20:35
Copy link
Contributor

@mlarose mlarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for the contribution

@mlarose mlarose merged commit b83481e into dagster-io:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart - runMonitoring: maxRuntimeSeconds not configurable
3 participants