[1/n][dagster-dlt] Move asset spec creation to DagsterDltTranslator.get_asset_spec #27207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximearmstrong
force-pushed
the
maxime/dlt-asset-spec-1
branch
from
241afbe to
df13790
Compare
maximearmstrong
force-pushed
the
maxime/dlt-asset-spec-1
branch
from
df13790 to
56c5f7f
Compare
maximearmstrong
force-pushed
the
maxime/dlt-asset-spec-1
branch
from
56c5f7f to
fc08bd8
Compare
This was referenced Jan 21, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -29,13 +61,13 @@ def get_asset_key(self, resource: DltResource) -> AssetKey: | |||
| def get_auto_materialize_policy(self, resource: DltResource) -> Optional[AutoMaterializePolicy]: | |||
| """Defines resource specific auto materialize policy. | |||
|
|
|||
| This method can be overriden to provide custom auto materialize policy for a dlt resource. | |||
| This method can be overrdidden to provide custom auto materialize policy for a dlt resource. | |||
There was a problem hiding this comment.
There is a typo in the docstring - overrdidden should be overridden
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Fixed in 538c4b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Move the asset spec creation from the asset decorator to a
get_asset_specmethod in the translator.Also updates adds tests. No additional test was added for group names, owners, automation condition and auto-materialize policies. It is not recommended to update these values by overriding
get_asset_specbecause they are not related to dlt specifically.How I Tested These Changes
Updated and new tests with BK