[components docs] Add dg components check to docs #27410
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...a_snippets/docs_beta_snippets_tests/snippet_checks/guides/components/test_components_docs.py
Outdated
Show resolved
Hide resolved
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
7 times, most recently
from
b826ea8 to
8edf00d
Compare
benpankow
force-pushed
the
benpankow/components-docs-test
branch
from
415b0bb to
1283883
Compare
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
4 times, most recently
from
9649573 to
a5d0888
Compare
benpankow
force-pushed
the
benpankow/components-docs-test
branch
from
96de8ae to
69ea005
Compare
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
from
a5d0888 to
e25d0d1
Compare
benpankow
force-pushed
the
benpankow/components-docs-test
branch
from
69ea005 to
abb9f78
Compare
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
2 times, most recently
from
aeeae7c to
5c2953d
Compare
benpankow
force-pushed
the
benpankow/components-docs-test
branch
from
fb2c492 to
9c38ec4
Compare
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
from
5c2953d to
fde2b17
Compare
benpankow
commented
Feb 1, 2025
| """, | ||
| ) | ||
| run_command_and_snippet_output( | ||
| cmd="dg component check --disable-cache --verbose --no-use-dg-managed-environment", |
There was a problem hiding this comment.
This ensures we test against the schema found in dev dagster, rather than the published modules. This is important in this case because this PR is stacked on a dagster-dbt schema fix which isn't published yet.
benpankow
force-pushed
the
benpankow/components-docs-add-check
branch
from
fde2b17 to
8fdd3fa
Compare
benpankow
changed the base branch from
master
to
benpankow/dbt-state-path-none
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-a07yny3o4-elementl.vercel.app Direct link to changed pages: |
smackesey
approved these changes
Feb 1, 2025
OwenKephart
approved these changes
Feb 1, 2025
schrockn
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a mention of
dg components checkto the intro docs, and corresponding test here.