-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Add workspace.yaml scaffolding (BUILD-652) #27477
base: master
Are you sure you want to change the base?
Conversation
5a68c83
to
c147077
Compare
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-nmgd6t8i9-elementl.vercel.app Direct link to changed pages: |
c147077
to
e5052e0
Compare
# for each code location. | ||
# | ||
# ##### EXAMPLE | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace after the # character to fix Vale linting error
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
e5052e0
to
0599367
Compare
We should consider directly jumping to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dg code-location scaffold will modify the workspace.yaml, injecting the necessary entry for the code location to be loaded in its own environment by dagster dev
Requesting changes based on this, which I do not think we should support. Let's just add the capability to pyproject.toml
0599367
to
42436ff
Compare
Hmm ok. Thought I would need this for |
Summary & Motivation
This adds
workspace.yaml
scaffolding todg deployment scaffold
anddg code-location scaffold
. We will want to replace this in the future with whateverpyproject.toml
-based replacement API we have in mind forworkspace.yaml
. But in the meantime, it makes sense to scaffoldworkspace.yaml
.dg deployment scaffold
will give you an emptyworkspace.yaml
(except for some explanatory comments)dg code-location scaffold
will modify theworkspace.yaml
, injecting the necessary entry for the code location to be loaded in its own environment bydagster dev
Caveats:
workspace.yaml
becomes adg
-managed file.How I Tested These Changes
New unit tests.