[components] Implement @local namespace for local components (BUILD-654) #27483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
changed the title
smackesey
force-pushed
the
sean/components/local-component-namespace
branch
from
d57cb9e to
9451334
Compare
smackesey
force-pushed
the
sean/components/registered-component-type
branch
from
2610382 to
b7b4367
Compare
smackesey
force-pushed
the
sean/components/local-component-namespace
branch
5 times, most recently
from
407c4f4 to
a6b7244
Compare
schrockn
requested changes
Feb 2, 2025
There was a problem hiding this comment.
Yeah let's discuss this. @OwenKephart @benpankow having to quote everything all the time is rough...
[INTERNAL_BRANCH=sean/components/registered-component-type]
smackesey
force-pushed
the
sean/components/registered-component-type
branch
from
b7b4367 to
bb42bc7
Compare
smackesey
force-pushed
the
sean/components/local-component-namespace
branch
from
a6b7244 to
71a39ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Change local component naming scheme. This:
Is now this:
(unfortunately the quotes are required with
@), which might be a reason to change it.How I Tested These Changes
Modified existing tests.