Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta banner from airlift docs site #27967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Feb 20, 2025

Summary & Motivation

Removes beta banner from airlift docs now that we have technical validation.

How I Tested These Changes

eyes

Copy link
Contributor Author

dpeng817 commented Feb 20, 2025

@dpeng817 dpeng817 requested review from neverett and yuhan February 20, 2025 23:02
@dpeng817 dpeng817 marked this pull request as ready for review February 20, 2025 23:02
@graphite-app graphite-app bot added the docs-to-migrate Docs to migrate to new docs site label Feb 20, 2025
Copy link
Contributor

graphite-app bot commented Feb 20, 2025

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (02/20/25)

1 label was added to this PR based on Christopher DeCarolis's automation.

Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-ktx7zr6pr-elementl.vercel.app
https://dpeng817-remove-beta-banner.archive.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor

yuhan commented Feb 20, 2025

does this need a changelog? slash do we need to change anything in docstring or code (like a flag or something)

@neverett
Copy link
Contributor

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (02/20/25)

@dpeng817 just flagging that we can remove this automation now

@neverett neverett added area: docs Related to documentation in general and removed docs-to-migrate Docs to migrate to new docs site labels Feb 26, 2025
Copy link
Contributor Author

@yuhan there are a few APIs listed as "beta". Are you asking if we need to remove the flag on those?

@dpeng817 dpeng817 force-pushed the dpeng817/remove_beta_banner branch from 288ea2a to cf63008 Compare March 11, 2025 21:41
import Beta from '../../partials/\_Beta.md';

<Beta />

Airlift is a toolkit for integrating Dagster and Airflow. Using [`dagster-airflift`](/api/python-api/libraries/dagster-airlift), you can:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo in the package name. The correct package name is dagster-airlift (not dagster-airflift), which would match the name used in the title and the beginning of the sentence. This should be corrected to ensure consistency and avoid confusion for users trying to find the package.

Suggested change
Airlift is a toolkit for integrating Dagster and Airflow. Using [`dagster-airflift`](/api/python-api/libraries/dagster-airlift), you can:
Airlift is a toolkit for integrating Dagster and Airflow. Using [`dagster-airlift`](/api/python-api/libraries/dagster-airlift), you can:

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is legit btw

@yuhan
Copy link
Contributor

yuhan commented Mar 12, 2025

i think your slack message answered my question - i was asking if we would remove all beta flags from all APIs, but seems like we'd keep some for now, and that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants