-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: link view transitions #1217
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Is this a temporary solution until React provides |
Yes. It's not perfect, but maybe good enough until then. |
I'm not super familiar with view transitions, but when we use it, do we use |
Let me add some commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My change makes it less handy, but I would like it as a temporary solution.
Sorry, that was too fast for me. I still had it on my list to investigate if this works for all cases.
I'll create some new tests for that when I have some time. |
I thought the example was working well.
Oops, sorry about it. |
Alternative approach to #1207. Instead of integrating view transitions for each route change, they are just optionally added to the
Link
click event.