Refactor: Modernize codebase with edition 2024#453
Merged
NSoiffer merged 2 commits intodaisy:mainfrom Jan 9, 2026
Merged
Conversation
NSoiffer
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking a bit through the Rust code and saw that MathCAT is still on Rust edition 2018.
The latest stable edition seems to be 2024.
It has some nice new stuff apparently (including basic things like compiler improvements), but most of it is too advanced for me for now (let's see in a few weeks), so I only fixed the incompatibilities:
src/canonicalize.rs, the borrowing now needs to be explicitsrc/interface.rs, setting an environment variable has to be manually marked asunsafesrc/speech.rs, therefkeyword is not allowed there because it's redundantFrom my understanding, a main theme of edition 2024 is making code more consistent, for example as we already have
&Yaml, so there shouldn't be an explicit borrowing-operator when it is already implicitly given.