Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool for generating border images #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bertfrees
Copy link
Member

@bertfrees bertfrees commented Sep 9, 2024

The idea is to eventually make it available as a server-side tool hosted on daisy.org, but for now a polyfill is required to resolve the special border-image URLs.

Preview

Being able to easily generate the source image for creating a border of braille characters is very convenient because the way the best practices document currently recommends creating borders is terribly complex (see the issue Do something about "magic numbers" in CSS examples).

The one issue I can see with this it that we currently don't allow remote resources.

The idea is to eventually make it available as a server-side tool
hosted on daisy.org, but for now a polyfill is required to resolve the
special border-image URLs.
@wfree-aph
Copy link
Collaborator

wfree-aph commented Sep 10, 2024

@bertfrees Apologies for my ignorance but I'm not understanding how this works. It seems like this feature would require someone using an eBraille file to have access to the internet. Is that true? It also seems like a feature that would make support on reading systems more complicated. I can understand why you're looking for a different approach than what we have without this feature but I'm just intimidated by the implications of what you're suggesting.

Edit: It also seems like something we should discuss with the Working Group before adding. The implications seem far-ranging.

@bertfrees
Copy link
Member Author

bertfrees commented Sep 10, 2024

It seems like this feature would require someone using an eBraille file to have access to the internet.

Yes, the way it is currently presented in the examples, it absolutely requires internet access. But nevertheless I think it would be better to recommend using the border-image approach for borders. I can see two solutions:

  • The author uses the DAISY service to generate the images and includes it in the eBraille file (manually, or it could be an authoring tool feature).
  • The author creates an eBraille file that uses remote resources, and then a preprocessing tool automatically downloads the resources, puts them inside the file, and updates the remote references.

Edit:

  • The third solution is to create a CSS extension. We could provide the JavaScript library for reading system implementors to use.

@bertfrees
Copy link
Member Author

bertfrees commented Sep 10, 2024

It also seems like a feature that would make support on reading systems more complicated. I can understand why you're looking for a different approach than what we have without this feature but I'm just intimidated by the implications of what you're suggesting.

Apart from the remote resource issue, I don't see why this would be more complicated for the reading system. What makes you say that?

Edit: to be clear, we are talking about border-image vs. the combination of border/padding/margin, right?

@bertfrees
Copy link
Member Author

I can see two solutions

A third solution is to create a CSS extension. We could provide the JavaScript library for reading system implementors to use.

@wfree-aph
Copy link
Collaborator

I can see two solutions

A third solution is to create a CSS extension. We could provide the JavaScript library for reading system implementors to use.

Would it be possible for us to discuss these solutions? A meeting with @bertfrees, @mattgarrish, and me would help me understand the implications here. Right now, I feel like I'm still nervous about the implications of each and if I understood the possibilities better, it would help me know what you're thinking.

@bertfrees
Copy link
Member Author

bertfrees commented Sep 11, 2024

Sure, I'm available for a meeting.

@bertfrees
Copy link
Member Author

Changes requested:

  • Don't recommend using the remote URLs. Instead, explain how to use the image generator tool to generate and download an image, store it inside the eBraille publication, and reference it from the CSS.
  • Mention that the ::before/::after approach may be used as an alternative to the border-image approach, as long as there are no left and right borders.
  • For completeness sake, also still mention the border-width/padding/margin approach, but keep it for last.
  • To get a good overview, divide the examples into three subsections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants