Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourceDate property #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add sourceDate property #269

wants to merge 1 commit into from

Conversation

mattgarrish
Copy link
Contributor

This pull request adds the property for expressing the date on which the source was published.

Should we also move this and sourcePublisher to the recommended properties list, as I asked in #221? Looking at the sourcePublisher definition, it says to add "N/A" if there isn't a source publisher, which is a strong case for not making it required.

Required metadata should always have a meaningful value, otherwise we keep having to propagate a workaround. It's never great to require language-specific values like "N/A", which I'll have to work into the date if we keep them required.

Fixes #200

Copy link
Collaborator

@clapierre clapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about the prefix "a11y" as these are not accessibility metadata.
Is there something more appropriate?

@mattgarrish
Copy link
Contributor Author

The source publisher and source publication date are pretty unique to accessible format production and we're using a11y as a prefix for metadata that is broadly needed for accessible formats. I wouldn't try to read too much into a prefix.

We're also constrained by epub's reserved prefixes. If we mint something new, then the prefix has to be declared every time until we can convince the epub wg to adopt it as a reserved prefix (and then get the spec updated, and then get epubcheck updated...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add brl:sourceDate
2 participants