Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include liveMatches in matches response #94

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Ma-ve
Copy link

@Ma-ve Ma-ve commented Nov 6, 2022

  • Adds isLive (bool) to the matches response
  • Adds a new endpoint, getLiveMatchById

edit: aww, the build is failing. I can't see why though. I've got one local warning that I can't seem to get rid of, which occurs when running npm run build. It does still properly build though. The error:


> @ma-ve/hltv-api@1.0.4 build
> tsc -p .

node_modules/cheerio/lib/options.d.ts:29:24 - error TS2304: Cannot find name 'URL'.

29     baseURI?: string | URL;
                          ~~~


Found 1 error in node_modules/cheerio/lib/options.d.ts:29

This occurs on any branch. I'm not that well versed in TS so I haven't got the slightest what's up.

@vercel
Copy link

vercel bot commented Nov 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hltv-api ❌ Failed (Inspect) Nov 16, 2022 at 8:58PM (UTC)

@vercel vercel bot temporarily deployed to Preview November 6, 2022 20:06 Inactive
@Ma-ve
Copy link
Author

Ma-ve commented Nov 6, 2022

@dajk Loving your project! Are you open to Pull requests? :-)

@dajk
Copy link
Owner

dajk commented Nov 12, 2022

Hi @Ma-ve ,

Thanks for contributing!

@dajk Loving your project! Are you open to Pull requests? :-)

Yes, sure. I will have a look what's wrong with the build ;)

@Ma-ve
Copy link
Author

Ma-ve commented Nov 13, 2022

@dajk
Hi @Ma-ve ,

Thanks for contributing!

@dajk Loving your project! Are you open to Pull requests? :-)

Yes, sure. I will have a look what's wrong with the build ;)

Cool, thank you!

@vercel vercel bot temporarily deployed to Preview November 16, 2022 20:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants