Improvement: Update CANFD library with 2517 compat toggle #753
+56
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvgalen
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the suggested changes to the pierremolinaro/acan2517FD library as suggested in this PR
Why
There is a performance gain, disabling 2517FD compat mode, it no longer disables interrupts during SPI transactions which slightly increases performance and avoids delaying interrupts. There should be no downside to enabling this, since our Wiki suggests using the 2518FD chip instead.
How
Disabling the MCP2517 compatibility mode can be done in ACAN2517FD.h by uncommenting the
#define DISABLEMCP2517FDCOMPATline. By default we keep this disabled until someone has had time to test it properly on a heavy bus load CAN-FD setup.