-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipython mimetypes extension #58
Open
znd4
wants to merge
8
commits into
daleroberts:master
Choose a base branch
from
znd4:add-ipython-extension
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
966868c
add ipython extension
znd4 2b727a9
try to fix import
znd4 78d37ce
try adding filename descriptor
znd4 1f15109
add second argument to lambda fn
znd4 56a1ff9
add debugging to imgcat process
znd4 a7c73a5
capture metadata for debugging
znd4 8f83f48
simplify implementation and document
znd4 49507ba
try to handle displaying strings
znd4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
""" | ||
ipython extensions for image output handling. | ||
e.g. | ||
|
||
```ipython | ||
%load_ext itermplot.ipython | ||
``` | ||
|
||
implemented based on https://ipython.readthedocs.io/en/stable/config/shell_mimerenderer.html | ||
""" | ||
|
||
from .. import imgcat | ||
|
||
|
||
def register_mimerenderer(ipython, mime, handler): | ||
ipython.display_formatter.active_types.append(mime) | ||
ipython.display_formatter.formatters[mime].enabled = True | ||
ipython.mime_renderers[mime] = handler | ||
|
||
|
||
def imgcat_factory(fn): | ||
def _wrapper(img, _): | ||
if isinstance(img, bytes): | ||
return imgcat(img, fn=fn) | ||
elif hasattr(img, "read"): | ||
return imgcat(img.read(), fn=fn) | ||
elif isinstance(img, str): | ||
return imgcat(img.encode(), fn=fn) | ||
else: | ||
raise ValueError( | ||
"imgcat only accepts bytes, file-like objects, and strings" | ||
) | ||
|
||
return _wrapper | ||
|
||
|
||
def load_ipython_extension(ipython): | ||
register_mimerenderer(ipython, "image/png", imgcat_factory(fn="img.png")) | ||
register_mimerenderer(ipython, "image/jpeg", imgcat_factory(fn="img.jpg")) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're okay with adding
load_ipython_extension
toitermplot/__init__.py
, it'd make this a cleaner%load_ext itermplot