Skip to content

Commit

Permalink
Merge pull request #143 from CasparJungbacker/halo-check
Browse files Browse the repository at this point in the history 
Check for overlapping halo's

If the MPI domain decomposition is such that either one of the local horizontal dimensions is smaller than the required number of ghost cells, the halo regions overlap and simulations will blow up eventually. This PR adds some simple checks to make sure this isn't the case.

Also did some formatting.
  • Loading branch information
@fjansson
fjansson authored Dec 7, 2024
2 parents 64cb191 + fc3fcf1 commit c7d95e1
Showing 1 changed file with 76 additions and 69 deletions.
145 changes: 76 additions & 69 deletions src/modstartup.f90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -410,93 +410,100 @@ subroutine startup(path)
end subroutine startup


!> Checks whether crucial parameters are set correctly
subroutine checkinitvalues
!-----------------------------------------------------------------|
! |
! Thijs Heus TU Delft 9/2/2006 |
! |
! purpose. |
! -------- |
! |
! checks whether crucial parameters are set correctly |
! |
! interface. |
! ---------- |
! |
! *checkinitvalues* is called from *program*. |
! |
!-----------------------------------------------------------------|

use modsurfdata,only : wtsurf,wqsurf,ustin,thls,isurf,ps,lhetero
use modglobal, only : itot,jtot, ysize,xsize,dtmax,runtime, startfile,lwarmstart,eps1, imax,jmax
use modmpi, only : myid,nprocx,nprocy,mpierr, MPI_FINALIZE
use modtimedep, only : ltimedep


if(mod(jtot,nprocy) /= 0) then
if(myid==0)then
write(6,*)'STOP ERROR IN NUMBER OF PROCESSORS'
write(6,*)'nprocy must divide jtot!!! '
write(6,*)'nprocy and jtot are: ',nprocy, jtot
end if
call MPI_FINALIZE(mpierr)
stop
else
if(myid==0)then
write(6,*)'jmax = jtot / nprocy = ', jmax
endif
use modsurfdata, only: wtsurf, wqsurf, ustin, thls, isurf, ps, lhetero
use modglobal, only: itot, jtot, ysize, xsize, dtmax, runtime, &
startfile, lwarmstart, eps1, imax, jmax, ih, jh
use modmpi, only: myid, nprocx, nprocy, mpierr, MPI_FINALIZE
use modtimedep, only: ltimedep

! Check MPI configuration
if (mod(jtot, nprocy) /= 0) then
if (myid == 0)then
write(6,'(A13,I4,A30,I4,A40)') 'ERROR: jtot (', jtot, ') is not &
&divisible by nprocy (', nprocy, '). Please change your MPI &
&configuration.'
end if
call MPI_FINALIZE(mpierr)
stop
else
if(myid == 0) then
write(6,*) 'jmax = jtot / nprocy = ', jmax
end if
end if

if(mod(itot,nprocx)/=0)then
if(myid==0)then
write(6,*)'STOP ERROR IN NUMBER OF PROCESSORS'
write(6,*)'nprocx must divide itot!!! '
write(6,*)'nprocx and itot are: ',nprocx,itot
end if
call MPI_FINALIZE(mpierr)
stop
else
if(myid==0)then
write(6,*)'imax = itot / nprocx = ', imax
endif
if (mod(itot, nprocx) /= 0) then
if (myid == 0) then
write(6,'(A13,I4,A30,I4,A40)') 'ERROR: jtot (', itot, ') is not &
&divisible by nprocy (', nprocx, '). Please change your MPI &
&configuration.'
end if
call MPI_FINALIZE(mpierr)
stop
else
if (myid == 0) then
write(6,*)'imax = itot / nprocx = ', imax
end if
end if

!Check Namroptions
! Check if we have overlapping ghost cells
if (ih > imax) then
if (myid == 0) then
write(6,'(A13,I4,A54,I4,A40)') 'ERROR: imax (', imax, ') is smaller &
&than the required number of ghost cells (', ih, '). Please change &
&your MPI configuration.'
end if
call MPI_FINALIZE(mpierr)
stop
end if

if (jh > jmax) then
if (myid == 0) then
write(6,'(A13,I4,A54,I4,A40)') 'ERROR: jmax (', jmax, ') is smaller &
&than the required number of ghost cells (', jh, '). Please change &
&your MPI configuration.'
end if
call MPI_FINALIZE(mpierr)
stop
end if

if (runtime < 0)stop 'runtime out of range/not set'
if (dtmax < 0) stop 'dtmax out of range/not set '
if (ps < eps1) stop 'psout of range/not set'
if (thls < eps1) stop 'thls out of range/not set'
if (xsize < 0) stop 'xsize out of range/not set'
if (ysize < 0) stop 'ysize out of range/not set '
! Check namoptions
if (runtime < 0) stop 'runtime out of range/not set'
if (dtmax < 0) stop 'dtmax out of range/not set'
if (ps < eps1) stop 'psout of range/not set'
if (thls < eps1) stop 'thls out of range/not set'
if (xsize < 0) stop 'xsize out of range/not set'
if (ysize < 0) stop 'ysize out of range/not set'

if (lwarmstart) then
if (startfile == '') stop 'no restartfile set'
end if
!isurf

! Surface
if (myid == 0) then
select case (isurf)
case(1)
case(2,10)
case(3:4)
if (wtsurf <-1e10) stop 'wtsurf not set'
if (wqsurf <-1e10) stop 'wqsurf not set'
case(11)
case default
stop 'isurf out of range/not set'
case (1)
case (2,10)
case (3:4)
if (wtsurf < -1E10) stop 'wtsurf not set'
if (wqsurf < -1E10) stop 'wqsurf not set'
case (11)
case default
stop 'isurf out of range/not set'
end select
if (isurf ==3) then
if (ustin < 0) stop 'ustin out of range/not set'

if (isurf == 3) then
if (ustin < 0) stop 'ustin out of range/not set'
end if
end if

if (ltimedep .and. lhetero) then
if (myid == 0) write(6,*)&
'WARNING: You selected to use time dependent (ltimedep) and heterogeneous surface conditions (lhetero) at the same time'
if (myid == 0) write(0,*)&
'WARNING: You selected to use time dependent (ltimedep) and heterogeneous surface conditions (lhetero) at the same time'
endif
if (myid == 0) then
write(6,*) 'WARNING: You selected to use time dependent (ltimedep) &
&and heterogeneous surface conditions (lhetero) at the same time'
end if
end if

end subroutine checkinitvalues

Expand Down

0 comments on commit c7d95e1

Please sign in to comment.