DEPHY input for nudging #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for per-variable nuging constants, as needed by the SEA-STARR case.
And set them to .true. for compatibility.
Profiles are provided until kmax in the old style input
To prevent segfaults
|
@fjansson I've tested the new setup for botany and it seems to run fine. From my part you can merge if you're fine with it too. |
fjansson
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of reading nudging profiles and nudging constants from a NetCDF input file in DEPHY format. Nudging constants can now be provided on a per-variable basis, allowing different constants for different variables. Also, did some cleanup, as always :)
Still need to test this a bit further with a case that actually uses nudging. Perhaps botany?
I also plan to implement nudging for tracers, but will make a separate PR for that.