refactor: use pagination for ListObjects to reduce memory usage #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11 - Add ListObjectsPaginated method with MaxKeys limit and continuation token - Add ListObjectsChannel method for streaming object iteration - Update BrowseBucket to use pagination (100 objects per page) - Update DeleteFolder to stream objects instead of loading all into memory - Update DownloadZip to stream objects instead of loading all into memory - Add pagination types: ListObjectsOptions, ListObjectsResult - Update mocks and journey tests for new methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Summary
When browsing buckets with many objects, IronBuckets was loading all objects into memory, causing OOMKilled errors in Kubernetes.
Changes
New Methods
ListObjectsPaginated: Returns a limited number of objects with pagination support (MaxKeys limit + continuation token)ListObjectsChannel: Returns a channel for streaming object iteration without loading all into memoryHandler Updates
BrowseBucket: Now uses pagination (100 objects per page) with "Load More" supportDeleteFolder: Streams objects and deletes one at a time instead of loading all into memoryDownloadZip: Streams objects into ZIP instead of loading all into memory firstTypes Added
ListObjectsOptions- Pagination options (Prefix, Recursive, MaxKeys, ContinuationToken)ListObjectsResult- Paginated results (Objects, IsTruncated, NextContinuationToken)DefaultPageSizeconstant (100)Testing