fix: redesign mobile hamburger menu as slide-out drawer #439
+368
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace centered dialog with left-side slide-out drawer (80vw, max 300px) - Add semi-transparent backdrop with click-to-dismiss - Add Escape key dismissal via Stimulus controller - Add proper aria-modal and aria-label for accessibility - Add CSS transform-based slide animation (300ms ease-in-out) - Touch targets meet WCAG 2.2 SC 2.5.8 minimum (24px) - Add 7 new system specs covering drawer behavior - Closes med-tracker-9fr9
- Add hamburgers CSS (Spring variant, compiled to plain CSS) - Replace ghost icon button with animated hamburger--spring toggle - Hamburger animates to X when drawer opens, reverses on close - Sheet controller toggles is-active class and aria-expanded - Sheet content controller calls back via Stimulus outlet to reset hamburger - Backdrop click and Escape key both dismiss drawer and reset icon - Prevents double-open with wrapper guard
- Use isConnected guard to allow re-opening after wrapper is removed from DOM - Reset hamburger via direct DOM query instead of broken Stimulus outlet - Call sheetController.close() via getControllerForElementAndIdentifier - Add regression test for open-close-open flow - Add screenshots showing all 4 drawer states
Owner
Author
Screenshots — Mobile Drawer (375×667 viewport)1. Closed state — Hamburger icon (Spring variant)
2. Drawer open — Slides from left with backdrop
3. After dismiss — Hamburger resets to three lines
4. Reopened — Drawer opens again after dismiss
Verified behaviors:
|
- Renders X icon button in drawer header next to MedTracker title - 44x44px touch target meets WCAG 2.2 SC 2.5.8 recommended size - aria-label="Close menu" for screen readers - Focus ring for keyboard navigation - Triggers sheet-content#close Stimulus action
Remove unnecessary grid gap-4 from single-child wrapper. py-4 provides section separation; inner gap-2 handles item spacing.
damacus
deleted the
cascade/coding-agent-servername-uri-mcp-beads-11ba22
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the mobile hamburger menu from a centered full-screen dialog to a proper left-side slide-out drawer.
Closes med-tracker-9fr9
Changes
SheetContent component
Sheet Stimulus controllers
Tests (7 new system specs)
Test Results