feat(robovac): select Tuya protocol version per model#277
Closed
feat(robovac): select Tuya protocol version per model#277
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements model-specific Tuya protocol version selection with a default of 3.3, adds comprehensive test coverage for protocol version handling, and removes the deprecated VacuumEntityFeature.BATTERY from model T2194 to comply with Home Assistant's enforced deprecation requirements.
Key Changes
- Added protocol version selection logic with per-model configuration support
- Implemented default protocol version 3.3 for models without explicit configuration
- Added comprehensive test suite for protocol version handling (tuple and float formats)
- Removed deprecated battery feature from T2194 model
- Generated updated documentation site files from MkDocs build
Reviewed changes
Copilot reviewed 42 out of 60 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_vacuum/test_protocol_version.py | New test suite validating protocol version selection and conversion logic |
| site/* (multiple HTML/CSS/JS files) | Generated documentation site files from MkDocs build process |
| requirements-dev.txt | Added mkdocs dependency for documentation generation |
| mkdocs.yml | New MkDocs configuration file for documentation structure |
| docs/* (multiple .md files) | New markdown documentation source files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ### Documentation | ||
|
|
||
| For more detailed information, please visit our [MkDocs documentation site](https://damacus.github.io/robovac/). |
There was a problem hiding this comment.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://damacus.github.io/robovac/ Status: 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select Tuya protocol version per model (default to 3.3) + add protocol version tests. Also removes deprecated VacuumEntityFeature.BATTERY from T2194 to satisfy enforced HA deprecation tests.